cleanup msgpack related str/bytes mess #6668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasWaldmann
changed the title
ThomasWaldmann
force-pushed
the
msgpack-str-bytes-cleanup
branch
2 times, most recently
from
2b5c32b
to
47304cd
Compare
ThomasWaldmann
force-pushed
the
msgpack-str-bytes-cleanup
branch
2 times, most recently
from
1bb35c6
to
cfdcf28
Compare
Codecov Report
@@ Coverage Diff @@
## master #6668 +/- ##
==========================================
- Coverage 82.75% 82.08% -0.68%
==========================================
Files 39 39
Lines 10739 10827 +88
Branches 2113 2129 +16
==========================================
Hits 8887 8887
- Misses 1330 1415 +85
- Partials 522 525 +3
Continue to review full report at Codecov.
|
ThomasWaldmann
force-pushed
the
msgpack-str-bytes-cleanup
branch
2 times, most recently
from
0e7d0ae
to
e0f65d4
Compare
this is somehow similar to borg recreate, but with different focus and way simpler: not changing compression algo not changing chunking not excluding files inside an archive by path match only dealing with complete archives but: different src and dst repo only reading each chunk once keeping the compressed payload (no decompression/recompression effort) --dry-run can be used before and afterwards to check
hack: see the docstring of ZLIB_legacy class. New clean ZLIB class that works as every other compressor. ZLIB ID 0x0500, ZLIB_legacy ID 0x.8..
Item.hlid: same id, same hardlink (xxh64 digest) Item.hardlink_master: not used for new archives any more Item.source: not used for hardlink slaves any more
…gbackup#2323 Timestamp scales to 64 or 96bit serialization formats, that should be enough for everybody. We use this in archived items and also in the files cache.
see ticket and borg.helpers.msgpack docstring.
see ticket and borg.helpers.msgpack docstring. this changeset implements the full migration to msgpack 2.0 spec (use_bin_type=True, raw=False). still needed compat to the past is done via want_bytes decoder in borg.item.
ThomasWaldmann
force-pushed
the
msgpack-str-bytes-cleanup
branch
from
e0f65d4
to
b2cfad4
Compare
|
will redo this PR against borg2 branch. #6704 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #6663, see the commits not prefixed with
transfer:.